[tests] Restore GetObjectArray coverage#12222
Merged
Merged
Conversation
Remove the stale global ignore now that the focused CoreCLR Release test passes, and improve diagnostics for peer identity and numeric conversion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1314df44-a447-444a-8b89-3867ce69224e
Contributor
There was a problem hiding this comment.
Pull request overview
Restores coverage for JNIEnv.GetObjectArray by re-enabling the previously ignored regression test and improving assertion diagnostics around Java peer identity and numeric conversion behavior.
Changes:
- Removes the global ignore on
GetObjectArray()(previously disabled due to historical CoreCLR failures). - Adds a dedicated NUnit category (
JNIObjectArray) for targeted execution/filtering. - Improves assertion diagnostics for context peer identity and
long→intconversion results.
jonathanpeppers
added
the
ready-to-review
rolfbjarne
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JNIEnv.GetObjectArrayregression test was globally ignored after a historical CoreCLR failure in #10973, leaving primitive conversion, Java peer identity, and mixed object-array marshaling uncovered on every runtime. The focused test now passes on current CoreCLR Release, so this restores it and adds clearer assertion diagnostics for peer identity and numeric conversion failures.Android.RuntimeTests.JnienvArrayMarshaling.GetObjectArraypassed 1/1 on CoreCLR Release (android-arm64, Pixel 5/API 34).