[TrimmableTypeMap] Add standalone integration coverage for generator-consumed scanner fields#10920
Draft
[TrimmableTypeMap] Add standalone integration coverage for generator-consumed scanner fields#10920
Conversation
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [TrimmableTypeMap] Add integration tests for generator-consumed scanner fields
[TrimmableTypeMap] Add standalone integration coverage for generator-consumed scanner fields
Mar 12, 2026
Member
|
@copilot build fails: |
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing TrimmableTypeMap integration tests only compared fields shared by the legacy Cecil scanner and the new SRM-based scanner. This change adds standalone correctness coverage for scanner fields that are consumed by the generator pipeline but have no legacy equivalent:
IsUnconditional,InvokerTypeName,CompatJniName, andMarshalMethodInfo.ManagedMethodName.Add standalone scanner integration tests
ScannerFieldIntegrationTestsundertests/Microsoft.Android.Sdk.TrimmableTypeMap.IntegrationTests/IsUnconditionalMono.Androidsanity check that MCW bindings are not marked unconditionalInvokerTypeNameresolution for interfaces and abstract typesCompatJniNameformat for user typesManagedMethodNamefor marshal methods, with a known-method spot checkExpand the user fixture to exercise missing paths
[ContentProvider]Align
CompatJniNamegeneration with compat format/before the type nameUserApp.MainActivity,MyBackgroundService,BootReceiver,SettingsProvider=>IsUnconditional == trueUserApp.MyBackupAgentbecomes unconditional via[Application(BackupAgent=typeof(...))]Android.Views.View+IOnClickListenerresolves toAndroid.Views.View+IOnClickListenerInvokerAndroid.Widget.AbsListViewresolves toAndroid.Widget.AbsListViewInvokerInvokerTypeName == nullOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.