Skip to content

Route CI Maven traffic through dotnet-public-maven - #1550

Merged
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-route-all-maven-traffic
Sep 22, 2026
Merged

jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-route-all-maven-traffic

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • Keep update / update-config version discovery on the configured Google Maven and Maven Central upstream repositories so new versions can be discovered before mirroring.
  • Route CI binderation, build, and artifact download traffic for both built-in Google Maven and Maven Central repositories through the dnceng dotnet-public-maven feed.
  • Preserve explicit URL and local directory repository behavior.
  • Add focused coverage for operation-specific CI and local repository routing.

Validation

  • Focused Maven routing tests: 8 passed
  • Full Xamarin.AndroidBinderator.Tests suite: 21 passed

Keep version discovery on the configured upstream repositories while routing binderation through dotnet-public-maven in CI.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 21, 2026 21:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review comments remain, and the changes have focused and full-suite test coverage.

Review effort: Lite
Findings: None

What changed in this PR

Routes CI Maven binderation, build, and artifact traffic through dotnet-public-maven while preserving upstream version discovery and explicit repository behavior.

Changes:

  • Added operation-aware Maven repository resolution.
  • Applied CI mirroring for Google Maven and Maven Central.
  • Preserved upstream version discovery and URL/local directory handling.
  • Added focused routing tests.
File Description
util/​Xamarin.AndroidBinderator/​Xamarin.AndroidBinderator/​MavenRepositoryResolver.cs Adds operation-specific CI routing.
util/​Xamarin.AndroidBinderator/​Xamarin.AndroidBinderator/​MavenFactory2.cs Routes binderation and artifact access through the CI mirror.
util/​Xamarin.AndroidBinderator/​Xamarin.AndroidBinderator/​MavenFactory.cs Preserves upstream repositories for version discovery.
util/​Xamarin.AndroidBinderator/​Xamarin.AndroidBinderator.Tests/​GenerationTests.cs Tests CI, upstream, URL, and directory routing.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operation-specific routing keeps version discovery upstream and sends CI artifact access through dotnet-public-maven while preserving explicit repositories and local behavior. The later same-revision CI run completes binderation and package builds with all 21 Binderator tests passing; the earlier feed-access failures are resolved.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
No pipelines were found matching this branch/path.

@jonathanpeppers
jonathanpeppers merged commit 1fb1e0c into main Sep 22, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-route-all-maven-traffic branch September 22, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants