Skip to content

Disable legacy package-reference pipelines on main - #4647

Open
paulmedynski wants to merge 1 commit into
mainfrom
dev/paul/disable-legacy-ci-package-pipelines
Open

Disable legacy package-reference pipelines on main#4647
paulmedynski wants to merge 1 commit into
mainfrom
dev/paul/disable-legacy-ci-package-pipelines

Conversation

@paulmedynski

@paulmedynski paulmedynski commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Limit the legacy package-reference pipelines so they no longer run:

  • For GitHub pull requests targeting main, dev/*, or feat/*.
  • From CI push triggers after merges to GitHub main.

Package-reference validation remains enabled for release branches. The existing scheduled runs on GitHub main and ADO internal/main remain enabled, as do CI push triggers for ADO internal/main and release branches.

This is an engineering-process-only change with no product API or runtime behavior changes.

Copilot AI balanced review requested due to automatic review settings September 4, 2026 18:25
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Sep 4, 2026
@paulmedynski paulmedynski added this to the 7.1.0 milestone Sep 4, 2026
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Sep 4, 2026
@paulmedynski
paulmedynski marked this pull request as ready for review September 4, 2026 18:26
@paulmedynski
paulmedynski requested a review from a team as a code owner September 4, 2026 18:26
@paulmedynski
paulmedynski enabled auto-merge (squash) September 4, 2026 18:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both pipeline headers still describe triggers that this change disables.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Limits legacy package-reference pipelines while preserving release and scheduled validation.

Changes:

  • Restricts PR validation to release/*.
  • Removes GitHub main CI push triggers while retaining schedules and ADO triggers.
File summaries
File Description
eng/pipelines/sqlclient-pr-package-ref-pipeline.yml Limits PR triggers to release branches.
eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml Disables GitHub main push triggers.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

# GitHub main and release branches.
- main
#
# GOTCHA: Currently disabled on main due to limited resources.
- feat/*
- main
#
# GOTCHA: Currently disabled on all but release/* due to limited resources.
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.48%. Comparing base (7054399) to head (933ae77).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4647      +/-   ##
==========================================
- Coverage   65.92%   64.48%   -1.44%     
==========================================
  Files         290      284       -6     
  Lines       44987    67980   +22993     
==========================================
+ Hits        29656    43837   +14181     
- Misses      15331    24143    +8812     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants