Tests | Add Flaky test details to ConnectionFailoverTests#4341
Open
cheenamalhotra wants to merge 2 commits into
Open
Tests | Add Flaky test details to ConnectionFailoverTests#4341cheenamalhotra wants to merge 2 commits into
cheenamalhotra wants to merge 2 commits into
Conversation
cheenamalhotra
commented
Jun 4, 2026
| /// and never attempts failover alternation. | ||
| /// </summary> | ||
| [Theory] | ||
| [Trait("Category", "flaky")] // Assert.Throws() Failure: No exception was thrown |
Member
Author
There was a problem hiding this comment.
New flaky test also found failing in pipelines
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ConnectionFailoverTests (simulated server unit tests) to capture additional context about recurring flaky failures, aiming to aid later diagnosis of intermittent CI issues in failover scenarios.
Changes:
- Annotates existing flaky theories/facts with inline failure summaries (assert diffs, timeouts, and SqlException details).
- Adds TODO blocks near assertions/open calls to preserve observed failure output for investigation.
- Marks an additional theory (
TransientFault_RetryDisabled_WithUserProvidedPartner_ShouldFail_NotFailover) asCategory=flakywith a brief failure note.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4341 +/- ##
==========================================
- Coverage 66.69% 64.55% -2.14%
==========================================
Files 284 279 -5
Lines 43238 66069 +22831
==========================================
+ Hits 28836 42653 +13817
- Misses 14402 23416 +9014
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some regularly failing tests from
ConnectionFailoverTestsclass, this PR adds failures/error message details for further investigation.