[6.1] SDK install retry. Disable flaky tests.#4332
Open
mdaigle wants to merge 2 commits into
Open
Conversation
To resolve, run: git cherry-pick 3499785
* Retry installing dotnet in CI + address flaky tests * One more flaky test
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Marks a subset of simulated-server unit tests as flaky and adds retry behavior to CI .NET installation steps to reduce intermittent pipeline failures.
Changes:
- Added
Trait("Category", "flaky")to specific simulated-server tests that intermittently fail. - Added
retryCountOnTaskFailure: 3to .NET SDK/runtime installation tasks (including ARM64 PowerShell step). - Documented the rationale for retries in the pipeline step YAML.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionRoutingTestsAzure.cs | Tags a specific Azure routing timeout test as flaky. |
| src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.cs | Tags transient-fault retry-disabled failover tests as flaky. |
| eng/pipelines/steps/install-dotnet.yml | Adds task-level retries and explanatory comments for intermittent SDK/runtime install failures. |
Comment on lines
+162
to
163
| [Trait("Category", "flaky")] | ||
| public void NetworkTimeoutAtRoutedLocation_RetryDisabled_ShouldFail() |
Comment on lines
+392
to
393
| [Trait("Category", "flaky")] | ||
| public void TransientFault_RetryDisabled_ShouldFail(uint errorCode) |
Comment on lines
+488
to
489
| [Trait("Category", "flaky")] | ||
| public void TransientFault_WithUserProvidedPartner_RetryDisabled_ShouldFail(uint errorCode) |
Comment on lines
63
to
66
| - task: UseDotNet@2 | ||
| displayName: Install .NET SDK (global.json) | ||
| retryCountOnTaskFailure: 3 | ||
| inputs: |
mdaigle
changed the title
cheenamalhotra
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #4314
This pull request improves reliability in CI pipelines by adding retry logic to .NET installation steps and marks certain flaky tests to help with test management. The most important changes are grouped below: