Eng | Disable ESRP steps on non-official pipelines#4077
Merged
cheenamalhotra merged 6 commits intomainfrom Mar 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OneBranch pipeline templates to prevent ESRP malware scanning and code-signing tasks from running in the non-official pipeline, addressing PRC compliance concerns about non-official builds accessing production signing resources.
Changes:
- Introduces an
isOfficialboolean threaded through OneBranch stage/job/step templates to gate ESRP tasks. - Updates official and non-official pipeline entrypoints to pass
isOfficial: true/falseintobuild-stages.yml. - Refactors pipeline instruction docs under
.github/instructions/to reflect the current OneBranch/CI pipeline structure and conventions.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/onebranch/steps/esrp-code-signing-step.yml | Adds isOfficial gate around ESRP malware scanning and signing steps. |
| eng/pipelines/onebranch/steps/compound-esrp-nuget-signing-step.yml | Gates NuGet malware scan/sign steps on isOfficial. |
| eng/pipelines/onebranch/steps/compound-esrp-dll-signing-step.yml | Gates DLL malware scan/sign steps on isOfficial. |
| eng/pipelines/onebranch/stages/build-stages.yml | Adds isOfficial parameter and threads it into build jobs. |
| eng/pipelines/onebranch/sqlclient-official.yml | Passes isOfficial: true into build stages. |
| eng/pipelines/onebranch/sqlclient-non-official.yml | Passes isOfficial: false into build stages. |
| eng/pipelines/onebranch/jobs/validate-signed-package-job.yml | Re-indents/normalizes YAML formatting (no functional gating added). |
| eng/pipelines/onebranch/jobs/build-signed-sqlclient-package-job.yml | Adds isOfficial parameter and passes it into ESRP signing step templates. |
| eng/pipelines/onebranch/jobs/build-signed-csproj-package-job.yml | Adds isOfficial parameter and threads it into compound ESRP signing steps. |
| .github/instructions/onebranch-pipeline-design.instructions.md | Replaces large design spec with a concise OneBranch editing guideline doc. |
| .github/instructions/ado-pipelines.instructions.md | Replaces general guide with concise CI/PR pipeline editing guideline doc. |
cheenamalhotra
added
the
Area\Engineering
cheenamalhotra
changed the title
paulmedynski
requested changes
Mar 24, 2026
eng/pipelines/onebranch/jobs/build-signed-csproj-package-job.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/onebranch/steps/compound-esrp-dll-signing-step.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/onebranch/steps/compound-esrp-nuget-signing-step.yml
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from In review
to In progress
in SqlClient Board
eng/pipelines/onebranch/jobs/build-signed-csproj-package-job.yml
Outdated
Show resolved
Hide resolved
paulmedynski
requested changes
Mar 24, 2026
eng/pipelines/onebranch/jobs/build-signed-csproj-package-job.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
paulmedynski
previously approved these changes
Mar 24, 2026
mdaigle
approved these changes
Mar 24, 2026
samsharma2700
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes PRC violations by disabling ESRP codesigning tasks on non-official pipelines.
Testing
Non-Official build: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=144627&view=results
Future Guidelines to follow: