Restore sync-over-async task consumption#3142
Open
timcassell wants to merge 2 commits into
Open
Conversation
timcassell
force-pushed
the
sync-task-consume
branch
from
6f6fe11 to
16ce011
Compare
timcassell
force-pushed
the
sync-task-consume
branch
2 times, most recently
from
2bdde9c to
22c527e
Compare
Refactor BenchmarkSynchronizationContext to not install SynchronizationContext.Current.
timcassell
force-pushed
the
sync-task-consume
branch
from
22c527e to
b51ab05
Compare
Contributor
|
Is it able to include docs/articles/guides/console-args.md update in this PR? After this PR is merged, I'll update #3162 to include this changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3139
Job.WithConsumeTasksSynchronously(true)or--consumeTasksSynchronously trueor[ConsumeTasksSynchronously(true)]option restores the previoustask.GetAwaiter().GetResult()benchmark behavior.false. I could be convinced to change the default totrueif we think preserving historical comparisons is more important than correct await behavior. @adamsitnikNo longer installs a
SynchronizationContext. This restores sync-over-async behavior in Params/ArgumentsSource (#3117), and it results in faster async measurements by default. Users can install a sync context themselves if they want that behavior. (Basically we still use the single-thread-pump context for internal awaits, but we don't leak it to user code/benchmarks.)