Skip to content

chore: replace dirname-filename-esm #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perrin4869 merged 1 commit into from
Jul 13, 2026
Merged

chore: replace dirname-filename-esm #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"@eslint-community/eslint-plugin-eslint-comments": "^4.7.2",
"@eslint/js": "^9.39.5",
"chai": "^6.2.2",
"dirname-filename-esm": "^1.1.2",
"eslint": "^9.39.5",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-import": "^2.32.0",
Expand Down
16 changes: 10 additions & 6 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { join } from "node:path";
import { readFileSync } from "node:fs";
import { expect } from "chai";
import { requireFromString, importFromStringSync } from "module-from-string";
import { dirname } from "dirname-filename-esm";

// https://github.com/import-js/eslint-plugin-import/issues/1649
// eslint-disable-next-line import/no-unresolved
Expand All @@ -11,7 +10,8 @@ import lua2js from "redis-lua2js";
describe("redis-lua2js", () => {
it("should export name and numberOfKeys from lua", () => {
const lua = readFileSync(
join(dirname(import.meta), "test_both.lua"),
// eslint-disable-next-line n/no-unsupported-features/node-builtins
join(import.meta.dirname, "test_both.lua"),
"utf8",
);

Expand All @@ -24,7 +24,8 @@ describe("redis-lua2js", () => {

it("should return null name and numeberOfKeys", () => {
const lua = readFileSync(
join(dirname(import.meta), "test_none.lua"),
// eslint-disable-next-line n/no-unsupported-features/node-builtins
join(import.meta.dirname, "test_none.lua"),
"utf8",
);

Expand All @@ -37,7 +38,8 @@ describe("redis-lua2js", () => {

it("should export name from lua and null numberOfKeys", () => {
const lua = readFileSync(
join(dirname(import.meta), "test_name.lua"),
// eslint-disable-next-line n/no-unsupported-features/node-builtins
join(import.meta.dirname, "test_name.lua"),
"utf8",
);

Expand All @@ -50,7 +52,8 @@ describe("redis-lua2js", () => {

it("should export null name and numberOfKeys from lua", () => {
const lua = readFileSync(
join(dirname(import.meta), "test_nkeys.lua"),
// eslint-disable-next-line n/no-unsupported-features/node-builtins
join(import.meta.dirname, "test_nkeys.lua"),
"utf8",
);

Expand All @@ -63,7 +66,8 @@ describe("redis-lua2js", () => {

it("should generate esm module", () => {
const lua = readFileSync(
join(dirname(import.meta), "test_both.lua"),
// eslint-disable-next-line n/no-unsupported-features/node-builtins
join(import.meta.dirname, "test_both.lua"),
"utf8",
);

Expand Down
Loading