Skip to content

fix(sdk): pin the remaining example apps to 1.2.0 instead of floating latest - #37503

Merged
KevinDavilaDotCMS merged 1 commit into
release-25.07.10_lts_v16from
36891-lts-v16-pin-remaining-examples
Sep 10, 2026
Merged

fix(sdk): pin the remaining example apps to 1.2.0 instead of floating latest#37503
KevinDavilaDotCMS merged 1 commit into
release-25.07.10_lts_v16from
36891-lts-v16-pin-remaining-examples

Conversation

@KevinDavilaDotCMS

@KevinDavilaDotCMS KevinDavilaDotCMS commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Completes the fix started in #37476 on this branch. That PR pinned examples/nextjs to 1.2.0; angular, astro and vuejs were left on "latest" and still resolve whatever the npm latest dist-tag points at today — currently a 26.x SDK against a 25.07.10 LTS server.

That is the same defect the customer hit in Freshdesk #38677, in the three apps nobody had reported yet.

App Before After
angular @dotcms/angular, client, types, uvelatest 1.2.0
astro @dotcms/client, react, types, uvelatest 1.2.0
vuejs @dotcms/clientlatest 1.2.0
nextjs already 1.2.0 (#37476) unchanged

Verification

  • Every package pinned here is published at 1.2.0: @dotcms/angular, @dotcms/client, @dotcms/react, @dotcms/types, @dotcms/uve — checked against the npm registry
  • validate-sdk-package-shapes (from SDK packaging: fix malformed version strings and floating/orphaned dist-tags (#36891) #37477) accepts all four manifests with --branch release-25.07.10_lts_v16
  • Diff is 9 insertions / 9 deletions: only @dotcms/* lines, each manifest's own indentation preserved (jq --indent matched per file — angular is 4-space, astro and vuejs are 2-space)

What a reviewer should weigh

1.2.0 is carried over from the nextjs pin, whose compatibility was established by static GraphQL schema analysis in #37476. That analysis covered the server contract these apps share, but @dotcms/angular was not part of it — it appears only in the angular example. If you want that verified independently before merging, say so and I will.

Why CI will not catch this class of bug on this branch

The guardrail added in #37477 lives in cicd_5-lts.yml on main. This branch runs its own July 2025 workflows, so the job does not exist here — confirmed on the latest run. Branch-scoped workflows only protect branches cut after the change.

Refs #36891

🤖 Generated with Claude Code

This PR fixes: #36891

… latest

PRs #37475/#37476 pinned examples/nextjs on this branch, leaving angular,
astro and vuejs still on "latest". Those three resolve whatever the npm
"latest" dist-tag points at today -- currently a 26.x SDK against a 25.07.10
LTS server -- which is the same defect the customer hit in Freshdesk #38677,
just in the apps nobody had reported yet.

Pinned to the same 1.2.0 the nextjs pin uses, so all four example apps on this
branch now agree. Every package involved (@dotcms/angular, client, react,
types, uve) is published at 1.2.0; verified against the registry.

The CI guardrail added in #37477 cannot catch this: it lives in cicd_5-lts.yml
on main and this branch runs its own July 2025 workflows.

Refs #36891

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@KevinDavilaDotCMS
KevinDavilaDotCMS merged commit 52216ea into release-25.07.10_lts_v16 Sep 10, 2026
3 of 6 checks passed
@KevinDavilaDotCMS
KevinDavilaDotCMS deleted the 36891-lts-v16-pin-remaining-examples branch September 10, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant