fix(sdk): pin the remaining example apps to 1.2.0 instead of floating latest - #37502
Merged
KevinDavilaDotCMS merged 1 commit intoSep 10, 2026
Conversation
… latest PRs #37475/#37476 pinned examples/nextjs on this branch, leaving angular, astro and vuejs still on "latest". Those three resolve whatever the npm "latest" dist-tag points at today -- currently a 26.x SDK against a 25.07.10 LTS server -- which is the same defect the customer hit in Freshdesk #38677, just in the apps nobody had reported yet. Pinned to the same 1.2.0 the nextjs pin uses, so all four example apps on this branch now agree. Every package involved (@dotcms/angular, client, react, types, uve) is published at 1.2.0; verified against the registry. The CI guardrail added in #37477 cannot catch this: it lives in cicd_5-lts.yml on main and this branch runs its own July 2025 workflows. Refs #36891 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
13 tasks
KevinDavilaDotCMS
merged commit Sep 10, 2026
135abb3
into
release-25.07.10_lts_v12
3 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the fix started in #37475 on this branch. That PR pinned
examples/nextjsto1.2.0;angular,astroandvuejswere left on"latest"and still resolve whatever the npmlatestdist-tag points at today — currently a 26.x SDK against a 25.07.10 LTS server.That is the same defect the customer hit in Freshdesk #38677, in the three apps nobody had reported yet.
angular@dotcms/angular,client,types,uve→latest1.2.0astro@dotcms/client,react,types,uve→latest1.2.0vuejs@dotcms/client→latest1.2.0nextjs1.2.0(#37475)Verification
1.2.0:@dotcms/angular,@dotcms/client,@dotcms/react,@dotcms/types,@dotcms/uve— checked against the npm registryvalidate-sdk-package-shapes(from SDK packaging: fix malformed version strings and floating/orphaned dist-tags (#36891) #37477) accepts all four manifests with--branch release-25.07.10_lts_v12@dotcms/*lines, each manifest's own indentation preserved (jq --indentmatched per file — angular is 4-space, astro and vuejs are 2-space)What a reviewer should weigh
1.2.0is carried over from the nextjs pin, whose compatibility was established by static GraphQL schema analysis in #37475. That analysis covered the server contract these apps share, but@dotcms/angularwas not part of it — it appears only in the angular example. If you want that verified independently before merging, say so and I will.Why CI will not catch this class of bug on this branch
The guardrail added in #37477 lives in
cicd_5-lts.ymlon main. This branch runs its own July 2025 workflows, so the job does not exist here — confirmed on the latest run. Branch-scoped workflows only protect branches cut after the change.Refs #36891
🤖 Generated with Claude Code
This PR fixes: #36891