Skip to content

fix(dotAI): forward maxCompletionTokens to Azure OpenAI builder for gpt-5.x and o-series models #36608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ihoffmann-dot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dotAI): forward maxCompletionTokens to Azure OpenAI builder for gpt-5.x and o-series models #36608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b28db
fix(dotAI): forward maxCompletionTokens to Azure OpenAI builder for g…
ihoffmann-dot Jul 16, 2026
67eb7ed
style(dotAI): add missing braces to all if statements in AzureOpenAiM…
ihoffmann-dot Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions dotCMS/src/main/java/com/dotcms/ai/client/langchain4j/AzureOpenAiModelProviderStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ public ChatModel buildChatModel(final ProviderConfig config, final String modelT
.apiKey(config.apiKey())
.endpoint(config.endpoint())
.deploymentName(deploymentName(config));
if (config.apiVersion() != null) builder.serviceVersion(config.apiVersion());
if (config.maxRetries() != null) builder.maxRetries(config.maxRetries());
if (config.timeout() != null) builder.timeout(Duration.ofSeconds(config.timeout()));
if (config.temperature() != null) builder.temperature(config.temperature());
if (config.maxTokens() != null && !requiresCompletionTokens(config)) builder.maxTokens(config.maxTokens());
if (config.apiVersion() != null) { builder.serviceVersion(config.apiVersion()); }
if (config.maxRetries() != null) { builder.maxRetries(config.maxRetries()); }
if (config.timeout() != null) { builder.timeout(Duration.ofSeconds(config.timeout())); }
if (config.temperature() != null) { builder.temperature(config.temperature()); }
if (config.maxTokens() != null && !requiresCompletionTokens(config)) { builder.maxTokens(config.maxTokens()); }
if (config.maxCompletionTokens() != null && requiresCompletionTokens(config)) { builder.maxCompletionTokens(config.maxCompletionTokens()); }
return builder.build();
}

Expand All @@ -42,11 +43,12 @@ public StreamingChatModel buildStreamingChatModel(final ProviderConfig config, f
.apiKey(config.apiKey())
.endpoint(config.endpoint())
.deploymentName(deploymentName(config));
if (config.apiVersion() != null) builder.serviceVersion(config.apiVersion());
if (config.maxRetries() != null) builder.maxRetries(config.maxRetries());
if (config.timeout() != null) builder.timeout(Duration.ofSeconds(config.timeout()));
if (config.temperature() != null) builder.temperature(config.temperature());
if (config.maxTokens() != null && !requiresCompletionTokens(config)) builder.maxTokens(config.maxTokens());
if (config.apiVersion() != null) { builder.serviceVersion(config.apiVersion()); }
if (config.maxRetries() != null) { builder.maxRetries(config.maxRetries()); }
if (config.timeout() != null) { builder.timeout(Duration.ofSeconds(config.timeout())); }
if (config.temperature() != null) { builder.temperature(config.temperature()); }
if (config.maxTokens() != null && !requiresCompletionTokens(config)) { builder.maxTokens(config.maxTokens()); }
if (config.maxCompletionTokens() != null && requiresCompletionTokens(config)) { builder.maxCompletionTokens(config.maxCompletionTokens()); }
return builder.build();
}

Expand All @@ -57,10 +59,10 @@ public EmbeddingModel buildEmbeddingModel(final ProviderConfig config, final Str
.apiKey(config.apiKey())
.endpoint(config.endpoint())
.deploymentName(deploymentName(config));
if (config.apiVersion() != null) builder.serviceVersion(config.apiVersion());
if (config.maxRetries() != null) builder.maxRetries(config.maxRetries());
if (config.timeout() != null) builder.timeout(Duration.ofSeconds(config.timeout()));
if (config.dimensions() != null) builder.dimensions(config.dimensions());
if (config.apiVersion() != null) { builder.serviceVersion(config.apiVersion()); }
if (config.maxRetries() != null) { builder.maxRetries(config.maxRetries()); }
if (config.timeout() != null) { builder.timeout(Duration.ofSeconds(config.timeout())); }
if (config.dimensions() != null) { builder.dimensions(config.dimensions()); }
return builder.build();
}

Expand Down Expand Up @@ -94,9 +96,9 @@ public ImageModel buildImageModel(final ProviderConfig config, final String mode
.baseUrl(config.endpoint())
.apiKey(config.apiKey())
.modelName(deploymentName(config));
if (config.size() != null) builder.size(config.size());
if (config.timeout() != null) builder.timeout(Duration.ofSeconds(config.timeout()));
if (config.maxRetries() != null) builder.maxRetries(config.maxRetries());
if (config.size() != null) { builder.size(config.size()); }
if (config.timeout() != null) { builder.timeout(Duration.ofSeconds(config.timeout())); }
if (config.maxRetries() != null) { builder.maxRetries(config.maxRetries()); }
return builder.build();
}
final OpenAiOfficialImageModel.Builder builder = OpenAiOfficialImageModel.builder()
Expand All @@ -108,9 +110,9 @@ public ImageModel buildImageModel(final ProviderConfig config, final String mode
if (config.apiVersion() != null) {
builder.azureOpenAIServiceVersion(AzureOpenAIServiceVersion.Companion.fromString(config.apiVersion()));
}
if (config.size() != null) builder.size(config.size());
if (config.timeout() != null) builder.timeout(Duration.ofSeconds(config.timeout()));
if (config.maxRetries() != null) builder.maxRetries(config.maxRetries());
if (config.size() != null) { builder.size(config.size()); }
if (config.timeout() != null) { builder.timeout(Duration.ofSeconds(config.timeout())); }
if (config.maxRetries() != null) { builder.maxRetries(config.maxRetries()); }
return builder.build();
}

Expand Down
Loading