Skip to content

refactor(skills): rename legacy skills to dot- convention#36469

Merged
nollymar merged 7 commits into
worktree-skill-governancefrom
skill-rename-legacy
Jul 13, 2026
Merged

refactor(skills): rename legacy skills to dot- convention#36469
nollymar merged 7 commits into
worktree-skill-governancefrom
skill-rename-legacy

Conversation

@nollymar

@nollymar nollymar commented Jul 8, 2026

Copy link
Copy Markdown
Member

Follow-up to #36466. Tracked by #36467.

Stacked PR — base is worktree-skill-governance (needs skills.config.json + skill-lint). Retarget to main after #36466 merges.

What

Brings the pre-dot- first-party skills into convention and adds required owner/status frontmatter, so they pass skill-lint as full first-party skills (removed from the grandfather list). Result: skill-lint passes with 0 warnings.

Old New Domain added?
dotcms-github-issues dot-issue-manage
cicd-diagnostics dot-cicd-diagnose
lts-backport dot-release-backport-lts
check-release-rollback dot-release-rollback-check + added missing frontmatter
vtl-migration dot-ui-vtl-migration
sdk-analytics dot-sdk-analytics sdk

skill-doctor stays grandfathered — it's a vendored/generic skill we didn't author, so it keeps its upstream name and no dot- prefix.

Note: The triage skill is not part of this rename — it is being migrated to a separate repo, so it has been removed here rather than renamed/governed. Its associated agents (dotcms-code-researcher, dotcms-issue-validator, dotcms-team-router, dotcms-duplicate-detector) and the /triage-pr-review command still live in .claude/ and are out of scope for this PR.

References updated (so nothing breaks)

  • /create-issue, /query-issue, /find-issues, /update-issue command bodies → point at dot-issue-manage
  • /check-release-rollback command body → dot-release-rollback-check
  • settings.json permission paths → dot-cicd-diagnose
  • Each renamed skill's internal self-path references (.claude/skills/<old>/…)

⚠️ Two things for reviewers to confirm

  1. Owners are best-guess placeholders (@dotcms/scout / @dotcms/platform) — please correct to the real owning teams.
  2. Directly-invoked skills change their slash-command name: /cicd-diagnostics → /dot-cicd-diagnose, /lts-backport → /dot-release-backport-lts, /vtl-migration → /dot-ui-vtl-migration, /sdk-analytics → /dot-sdk-analytics. Command-fronted skills (issue commands, rollback check) keep their command names. If any /old-name muscle memory is heavily used, we can add thin alias commands — flag it.

Verified

just skills-lint → ✅ pass, 7 first-party skills, 0 warnings (was 3 legacy warnings before). Catalog regenerated. Swept for stale old-name references — none remain in tracked files.

🤖 Generated with Claude Code

Bring pre-dot- first-party skills into the naming convention and add
required owner/status frontmatter, so they pass skill-lint as full
first-party skills (no longer grandfathered).

Renames:
- triage                 -> dot-issue-triage
- dotcms-github-issues   -> dot-issue-manage
- cicd-diagnostics       -> dot-cicd-diagnose
- lts-backport           -> dot-release-backport-lts
- check-release-rollback -> dot-release-rollback-check (also added missing frontmatter)
- vtl-migration          -> dot-ui-vtl-migration
- sdk-analytics          -> dot-sdk-analytics (added 'sdk' domain)

- skill-doctor stays grandfathered (vendored/generic, not dot- prefixed)
- Updated all references: /create|query|find|update-issue and
  /check-release-rollback command bodies, settings.json paths, and
  each skill's internal self-path references
- owner values are best-guess placeholders — teams must confirm

Note: skills invoked directly change slash-command name (e.g. /triage ->
/dot-issue-triage). Command-fronted skills keep their command names.

Stacked on the skill-governance base branch. Part of #36467.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mergify

mergify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@claude

claude Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @nollymar's task in 3m 5s —— View job


Review — PR #36469: rename legacy skills to dot- convention

  • Read full diff vs origin/worktree-skill-governance
  • Verified functional references (script paths, command bodies, settings, config)
  • Swept the committed tree for stale old-name references
  • Posted review

The rename itself is clean and internally consistent. I verified the parts that would actually break at runtime:

  • ✅ Executable self-paths in dot-cicd-diagnose/SKILL.md (diagnose.py, sys.path.insertdot-cicd-diagnose/utils) all updated.
  • dot-cicd-diagnose/utils/README.md sys.path examples updated; no hardcoded old paths in any .py.
  • ✅ Command bodies (/create-issue, /find-issues, /query-issue, /update-issuedot-issue-manage; /check-release-rollbackdot-release-rollback-check) retargeted.
  • settings.json permission globs → dot-cicd-diagnose.
  • skills.config.json: sdk added to approvedDomains, grandfather list reduced to skill-doctor, note updated.
  • dot-release-rollback-check/SKILL.md gains the missing owner/status/name frontmatter.
  • ✅ Remaining old-name strings inside the renamed skill dirs are prose only — changelog history, the sdk-analytics npm-package keyword in dot-sdk-analytics description, README narrative. Harmless.

New Issues

  • 🟡 Medium: ONBOARDING.md:264,273,275,276 — Section 7 ("Claude Code skills available in this repo") still lists the old skill names: cicd-diagnostics, dotcms-github-issues, vtl-migration, check-release-rollback. Since directly-invoked skills change their slash-command name (/cicd-diagnostics → /dot-cicd-diagnose, etc.), this onboarding doc now hands new developers invocation names that no longer resolve. This file wasn't touched by the PR, so the "no stale references remain in tracked files" claim in the description isn't quite accurate. Fix this →

  • 🟡 Medium: ONBOARDING.md:272 — Lists a triage skill that this PR deletes (.claude/skills/triage/SKILL.md removed). New devs following onboarding would try to invoke a skill that no longer exists. Remove the entry (or point at the separate repo it's migrating to).

  • 🟡 Medium: .mise.toml:19 — Comment still reads # Python for cicd-diagnostics skill. Cosmetic (a comment, nothing resolves it), but it's the same rename the PR is making everywhere else. The companion .mise.md was updated; .mise.toml was missed.

None of these block merge — they're documentation drift in files outside the diff, not defects in the rename. But the PR body states the sweep found no remaining references, and these four spots contradict that, so worth cleaning up in this PR while it's fresh.

Note (not a defect)

The .mise.md (updated by this PR) references .claude/skills/dot-cicd-diagnose/fetch-logs.py / fetch-jobs.py / fetch-metadata.py, but the skill actually ships a single diagnose.py. That mismatch is pre-existing (the old names were equally wrong) — flagging only in case you want to correct it in the same doc pass.
· branch skill-rename-legacy

@nollymar nollymar linked an issue Jul 8, 2026 that may be closed by this pull request
10 tasks
nollymar and others added 2 commits July 10, 2026 18:03
Resolve skills.config.json conflict: keep both the 'sdk' approved domain
(this PR) and the 'deprecated' valid status (base branch).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Set owner to @dotCMS/falcon for dot-sdk-analytics and dot-ui-vtl-migration
- Fix stale .claude/skills/cicd-diagnostics/ path refs in .mise.md → dot-cicd-diagnose
- Fix stale /cicd-diagnostics slash-command and dir tree in dot-cicd-diagnose/README.md
- Fix stale /lts-backport slash-command refs in dot-release-backport-lts/SKILL.md
- Regenerate CATALOG.md

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nollymar and others added 2 commits July 13, 2026 13:04
The dot-issue-triage skill is being migrated to a separate repo, so it
should not be governed/renamed here. Removes the skill directory, drops
the CONTRIBUTING example that referenced it, and regenerates CATALOG.md
(7 first-party skills). skill-lint passes with 0 warnings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…skill-rename-legacy

# Conflicts:
#	.claude/skills/CONTRIBUTING.md
@nollymar
nollymar merged commit caffb20 into worktree-skill-governance Jul 13, 2026
27 checks passed
@nollymar
nollymar deleted the skill-rename-legacy branch July 13, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Skill governance: dot- naming convention, catalog, lint & CI gate

3 participants