Say what ending a process sets off, and look at the process again before ending it - #35
Merged
Merged
Conversation
…ore ending it A forced stop now reads what Windows does once the process is gone. A process Windows marks critical, or a service with "restart the computer" anywhere in its recovery actions, is refused - ending it takes the machine down - and so are recovery actions or a critical flag that cannot be read. A service Windows starts again by itself, one whose recovery runs a program, and a recovery action of a kind the tool cannot name are warned about in the preview (recoveryRestarts, recoveryRunsProgram, recoveryUnnamed - new warning kinds). The step that ends the process reads who lives in it just before it does, and ends nothing if a service moved into it or a running service outside it began to depend on something inside it since the preview. After the ending, an entry seen in a new process is reported at once as ended and started again, instead of after the whole limit as having run out of time. Measured on a throwaway machine with a test service before and after: with a restart at 0 ms the step used to time out after 60 s over a process that died at once, and now reports it in about 0.1 s. The flag that widens recovery actions to polite stops changes nothing about an ending, so it is not read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package B2 of the stability report: a forced stop says what ending the process sets off, and looks at the process once more before ending it.
What changes for a user
recoveryRestarts,recoveryRunsProgram,recoveryUnnamed."outcome": "failed",errorCode0), instead of after the whole limit astimedOut.How it was checked
sc.exe qfailure- 312 of 312 services agree.bws kill --dry-runon this machine: Spooler and Schedule get the new warnings, RpcSs and mpssvc are refused as critical processes.Not checked
🤖 Generated with Claude Code