feat: add version metadata and CLI -h/-v flags#94
Conversation
Declare ldflags-injected build variables, print them for -v/--version, and add -h/--help usage. Stamp release binaries with the same metadata as build.sh. Fixes dolph#26
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfc9137a12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Remove date/time from logging output. | ||
| log.SetFlags(0) | ||
|
|
||
| if len(args) == 2 && (args[1] == "-v" || args[1] == "--version") { |
There was a problem hiding this comment.
AGENTS.md says any added flag or subcommand must update the README in the same PR. This block adds -v/--version (and the -h/--help block below), but README.md still documents only find-replace FIND REPLACE, so users have no documented way to discover the new supported flags and the change violates the repo's CLI-surface rule.
Useful? React with 👍 / 👎.
Summary
GitTag,GitCommit, etc.) and print them via-v/--version-h/--helpusage output instead of only failing on wrong aritybuild.shTest plan
go test -run 'Version|Help' ./..../find-replace --versionshows stamped metadata after buildFixes #26
Made with Cursor