Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions find_replace.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ func (fr *findReplace) WalkDir(f *File) {
}

for _, file := range files {
if file.Type()&os.ModeSymlink != 0 {
continue
}
childPath := filepath.Join(f.Path, file.Name())
childFile, err := NewFile(childPath)
if err != nil {
Expand Down Expand Up @@ -151,6 +154,12 @@ func (fr *findReplace) WalkDir(f *File) {
// the rename step; the failure is returned so the walker can log it and
// continue with siblings.
func (fr *findReplace) HandleFile(f *File) error {
if li, err := os.Lstat(f.Path); err != nil {
return err
} else if li.Mode()&os.ModeSymlink != 0 {
return nil
}

info, err := f.Info()
if err != nil {
return err
Expand Down
31 changes: 31 additions & 0 deletions find_replace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,37 @@ func withWorkingDir(t *testing.T, dir string) {
t.Cleanup(func() { _ = os.Chdir(prev) })
}


func TestHandleFileSkipsSymlink(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("symlink test requires unix")
}
dir := t.TempDir()
target := filepath.Join(dir, "target.txt")
if err := os.WriteFile(target, []byte("secret"), 0o644); err != nil {
t.Fatal(err)
}
link := filepath.Join(dir, "link.txt")
if err := os.Symlink(target, link); err != nil {
t.Fatal(err)
}
f, err := NewFile(link)
if err != nil {
t.Fatal(err)
}
fr := findReplace{find: "secret", replace: "public"}
if err := fr.HandleFile(f); err != nil {
t.Fatal(err)
}
got, err := os.ReadFile(target)
if err != nil {
t.Fatal(err)
}
if string(got) != "secret" {
t.Fatalf("symlink target modified: %q", got)
}
}

func CloneRepoToTestDir(b *testing.B, repoUrl string) *File {
b.Helper()
d := newTestDir(b, "", "*")
Expand Down