chore: bump doclling serve testcontainer to 1.35.0 - #702
Merged
Merged
Conversation
edeandrea
enabled auto-merge (squash)
September 24, 2026 17:28
:java_duke: JaCoCo coverage report
Files
|
|
||||||||||||||
Signed-off-by: Eric Deandrea <eric@ericdeandrea.dev>
edeandrea
force-pushed
the
docling-serve-1.35.0
branch
from
September 25, 2026 01:14
53a24a8 to
076740d
Compare
docling-serve names extracted images after a hash of their content, so the hash changes whenever the rendered image bytes do. The bump to docling-serve 1.35.0 changed it, breaking the ZIP entry assertions that hardcoded the old value. assertZipArchiveEntries now replaces the hash in artifacts/image_NNNNNN_<hash>.png entry names with a placeholder before comparing, so the tests still verify the exact set of entries without depending on the image bytes.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.