Repository navigation
docker: Match version format with ce-packaging - #529
Merged
Merged
Conversation
`docker version` showed the full 40-character commit for binaries built here. Packages from docker-ce-packaging, and the engine deb and rpm packages here, show the 7-character short hash. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Static docker-cli and docker-engine archives still reported versions like v29.9.0-rc.2 in `docker version`. The earlier change that dropped the prefix covered the deb, rpm, and combined docker builds, but missed these two static build scripts. Strip the prefix from GENVER_VERSION before passing it to the CLI and Engine builds, as the other builds already do. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use short Git commit in docker CLI and engine version output
docker versionshowed the full 40-character commit for binaries built here. Packages from docker-ce-packaging, and the engine deb and rpm packages here, show the 7-character short hash.pkg: Drop the v prefix from static CLI and Engine versions
Static docker-cli and docker-engine archives still reported versions like v29.9.0-rc.2 in
docker version.The earlier change that dropped the prefix covered the deb, rpm, and combined docker builds, but missed these two static build scripts.
Strip the prefix from GENVER_VERSION before passing it to the CLI and Engine builds, as the other builds already do.