Repository navigation
Conversation
This comment was marked as spam.
This comment was marked as spam.
crazy-max
force-pushed
the
bake-vars
branch
2 times, most recently
from
October 5, 2026 13:18
390133a to
24c9901
Compare
crazy-max
marked this pull request as ready for review
October 5, 2026 13:20
crazy-max
force-pushed
the
bake-vars
branch
2 times, most recently
from
October 5, 2026 14:16
cfe01fc to
1bbde63
Compare
tonistiigi
reviewed
Oct 13, 2026
tonistiigi
left a comment
tonistiigi
left a comment
Member
There was a problem hiding this comment.
How will the DOCKER_METADATA_OUTPUT_ be handled after this change? Don't we need some special case for it as well?
Member
Author
Good catch, opened docker/actions-toolkit#1373 Edit: Also needs docker/bake-action#530 |
Disable ambient Bake variable lookup so runner environment values cannot implicitly override the definition. Use BakeVars to forward CI, GITHUB_, RUNNER_ and DOCKER_METADATA_OUTPUT_ values, preserving caller precedence. Pass variables explicitly to definition validation and bake-action. Serialize the action input as JSON to preserve multiline metadata values. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs
Disable ambient Bake variable lookup so workflow and runner environment values cannot implicitly override the Bake definition. Pass caller-provided variables explicitly to both definition validation and
docker/bake-action.Use the
BakeVarshelper to forwardCIand variables withGITHUB_,RUNNER_orDOCKER_METADATA_OUTPUT_prefixes, with caller-provided values taking precedence. Serialize the action input as JSON to preserve multiline metadata values. The workflow fixture verifies allowed variable forwarding, multiline tags and labels, caller overrides, and exclusion of unrelated environment values.