guides: minor layout fixes#24679
Merged
craig-osterhout merged 1 commit intodocker:mainfrom Apr 10, 2026
Merged
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR makes two layout improvements to the guides landing page:
- Conditional filter display: Adds checks to only show tags and languages that have associated guides, preventing empty filter options
- Text overlap fix: Removes
md:flex-nowrapto prevent chip text overlap at medium widths
The Hugo template syntax is correct, and the logic is sound. The conditional checks using where with intersect will properly filter out unused tags/languages. The CSS change is a valid UX improvement that allows wrapping at all screen sizes to prevent overflow.
No bugs or issues found. The changes are minimal, focused, and address the stated problems effectively.
aevesdocker
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At just the right medium width, some chips' text overlaps. Removed no wrap for medium.
Some tags in the left-nav have no guides (release notes, secrets, etc.). Added conditional to make sure the tag and language has associated guides before displaying
https://deploy-preview-24679--docsdocker.netlify.app/guides/?tags=distributed-systems
Related issues or tickets
ENGDOCS-3227
Reviews