Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
content/manuals/enterprise/security/hardened-desktop/settings-management/settings-reference.md
Outdated
Show resolved
Hide resolved
content/manuals/enterprise/security/hardened-desktop/settings-management/settings-reference.md
Outdated
Show resolved
Hide resolved
content/manuals/enterprise/security/hardened-desktop/settings-management/settings-reference.md
Outdated
Show resolved
Hide resolved
content/manuals/enterprise/security/hardened-desktop/settings-management/settings-reference.md
Outdated
Show resolved
Hide resolved
content/manuals/enterprise/security/hardened-desktop/settings-management/settings-reference.md
Outdated
Show resolved
Hide resolved
| - **General** setting in [Docker Desktop GUI](/manuals/desktop/settings-and-maintenance/settings.md) | ||
| - Settings Management: `desktopTerminalEnabled` setting in the [`admin-settings.json` file](/manuals/enterprise/security/hardened-desktop/settings-management/configure-json-file.md) | ||
|
|
||
| This reference documents Docker Desktop settings that administrators can configure using [Settings Management](/manuals/enterprise/security/hardened-desktop/settings-management/_index.md). Use this page to understand which settings are available, their accepted values, platform compatibility, and which configuration methods apply. |
There was a problem hiding this comment.
| This reference documents Docker Desktop settings that administrators can configure using [Settings Management](/manuals/enterprise/security/hardened-desktop/settings-management/_index.md). Use this page to understand which settings are available, their accepted values, platform compatibility, and which configuration methods apply. | |
| This reference documents Docker Desktop settings that administrators can configure using [Settings Management](/manuals/enterprise/security/hardened-desktop/settings-management/_index.md). Use this page to understand the settings that are available, their accepted values, platform compatibility, and which configuration methods apply. |
| > In hardened environments, disable and lock this setting. | ||
|
|
||
| #### osxfs | ||
| > This page covers admin-configurable settings only. Settings that are only available to end users via the Docker Desktop GUI are not included here. For the full list of Docker Desktop user-facing settings, see [Change settings](/manuals/desktop/settings-and-maintenance/settings.md). |
There was a problem hiding this comment.
This is a little confusing and I wonder if a parallel construction can help differentiate admin/end user. maybe something like:
"This page only covers configurable settings for administrators who are deploying Docker Desktop to their orgs. Docker Desktop GUI settings for individual end users can be found at ."
Something like this but this ^ isn't the best either lol
| > In hardened environments, disable and lock this setting. This allows you | ||
| to control all your data flows and collect support logs via secure channels | ||
| if needed. | ||
| | Property | Value | |
| > | ||
| > In hardened environments, lock to an explicit allowlist and disable end-user | ||
| edits. | ||
| > **Important:** Docker Business customers must set this to `"Enabled"` or `"Always Enabled"` in the Admin Console. Setting to `"User Defined"` alone will not activate Gordon. |
There was a problem hiding this comment.
This looks a little odd, do we want to make this into a call out or maybe two bullet points?
| | Admin Console | **Containers proxy** section | | ||
|
|
||
| ## Notifications settings | ||
| ```json |
There was a problem hiding this comment.
Can we add a little context of how this json object relates to the section? Nothing too intense, could also be a code comment.
Feedback we get around our admin personas is that they have a little less technical expertise than a lot of our long time docker users. Adding context is a nice way to help Schroedinger's beginner user w/o making a big to do with a tutorial or something.
| | JSON key | ``dockerSocketMount` | | ||
| | Admin Console | **Image list**, **Command list** | | ||
|
|
||
| ```json |
There was a problem hiding this comment.
ibid above; maybe overkill and not a blocker but could be nice to have
akristen
left a comment
akristen
left a comment
There was a problem hiding this comment.
This is a big improvement. I made a few little nits that shouldn't be blocking.
One thing I'm wondering that might clean up the doc is maybe having a TOC max frontmatter variable that doesn't reveal the h3s in the ToC. I think the benefit of including h3s in some docs is to add context at-a-glance, but this ToC is so long that it's not really glanceable. But hiding the h3s could give it a cleaner/less overwhelming feel. Not a blocker by any means tho and just an idea!
2 participants
Description
Related issues or tickets
Reviews