Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dvdksn
force-pushed
the
sandboxes-461
branch
from
50e2957 to
2952463
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Update workspace defaults/behavior and automatic sandbox naming.
Add canonical reference section for default network policy configuration, including policy mode, blocked CIDRs, and allowed hosts.
Document that credentials are scoped per agent with no fallback authentication methods.
dvdksn
force-pushed
the
sandboxes-461
branch
from
2952463 to
8aec906
Compare
Add documentation for mounting multiple workspaces to a single sandbox, with support for read-only mounts
Replace deprecated --load-local-template flag with new --pull-template
dvdksn
force-pushed
the
sandboxes-461
branch
from
8aec906 to
88d39af
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
sandboxes-461
branch
from
ff5841a to
d97f161
Compare
dvdksn
added
the
status/do-not-merge
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Found 5 issues in the sandboxes v0.12.0 documentation:
- 1 medium severity: Grammatical error in cagent.md
- 1 medium severity: Inconsistent placeholder usage in workflows.md
- 1 medium severity: Incomplete example in quick start (_index.md)
- 1 medium severity: Incomplete explanation in gemini.md
- 1 low severity: Subject-verb agreement in migration.md
All issues are in newly added or modified content.
| {{< summary-bar feature_name="Docker Sandboxes" >}} | ||
|
|
||
| This guide covers authentication, configuration, and usage of Docker cagent in | ||
| a sandboxed environment. [cagent](/ai/cagent/) is Docker's open source coding |
There was a problem hiding this comment.
Grammatical error: missing plural
The phrase "supports multiple provider" should be "supports multiple providers" (plural).
| a sandboxed environment. [cagent](/ai/cagent/) is Docker's open source coding | |
| agent that supports multiple providers. |
| Docker Desktop 4.58 introduces microVM-based sandboxes, replacing the previous | ||
| container-based implementation. This guide helps you migrate from legacy | ||
| sandboxes to the new architecture. | ||
| The most recent versions of Docker Desktop creates microVM-based sandboxes, |
There was a problem hiding this comment.
Subject-verb agreement error
"The most recent versions" (plural) should use "create" (plural verb), not "creates" (singular).
| The most recent versions of Docker Desktop creates microVM-based sandboxes, | |
| The most recent versions of Docker Desktop create microVM-based sandboxes, |
|
|
||
| ```console | ||
| $ docker sandbox run claude ~/my-project | ||
| $ cd ~/my-project |
There was a problem hiding this comment.
Quick start example could be more actionable
The generic AGENT placeholder makes this example less immediately useful. Consider showing a concrete example that users can copy and run, like:
| $ cd ~/my-project | |
| $ cd ~/my-project | |
| $ docker sandbox run claude |
You could then add a note like "(Replace claude with your preferred agent)"
| ```console | ||
| $ docker sandbox run AGENT ~/my-project | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Inconsistent placeholder usage
This file uses uppercase AGENT as a placeholder, but later examples in the same file use concrete agent names like claude, codex, etc. For consistency and clarity, consider using a concrete example here too:
| $ docker sandbox run claude |
| Gemini is in active development. Known considerations: | ||
|
|
||
| - Features may change between Docker Desktop versions | ||
| - Proxy authentication is a workaround for CLI limitations |
There was a problem hiding this comment.
Incomplete explanation of workaround
"Proxy authentication is a workaround for CLI limitations" doesn't explain what those limitations are. Consider clarifying:
| - Proxy authentication is a workaround for CLI limitations | |
| Proxy authentication is a workaround for Gemini CLI's OAuth flow limitations. The CLI's built-in OAuth flow doesn't work well in containerized environments, so the sandbox uses proxy-based authentication with API keys instead. |
2 participants
Assorted sandboxes updates for dd 4.61 / sandboxes v0.12.0