added manual for creating own DHI image#24075
added manual for creating own DHI image#24075ajeetraina wants to merge 11 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Currently, working on a scenario that captures "Using OCI artifacts as package sources". |
Updated the title and linktitle for clarity, refined keywords, and added a section on building a catalog image. Adjusted descriptions for the os-release block and enhanced the examples for using OCI artifacts.
|
Ran vale and fixed few formatting issue. |
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Documentation Review
Thank you for this comprehensive guide on building Docker Hardened Images! The content is well-structured and provides valuable information for users. I found a few minor clarity improvements that would enhance the documentation:
Summary
- ✅ Good technical accuracy and complete examples
- ✅ Clear step-by-step instructions
- ✅ Helpful YAML schema reference tables
- 💬 Minor terminology and clarity improvements suggested below
Note: Found 3 minor issues (1 confirmed, 2 likely improvements). The documentation is clear overall - these are small refinements for consistency with the style guide.
Updated the description of the DHI build process for clarity and accuracy.
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Editorial-wise, LGTM
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
looks good - some optional comments/qs but feel free to merge
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
3 participants
Description
This PR adds a missing manual of building your own custom DHI image based on Alpine and Debian.
Related issues or tickets
Reviews