Skip to content

build: match dockerignore names case-sensitively #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
locker95 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

build: match dockerignore names case-sensitively #3451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docker/utils/fnmatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
corresponding to PATTERN. (It does not compile it.)
"""

import os
import re

__all__ = ["fnmatch", "fnmatchcase", "translate"]
Expand Down Expand Up @@ -39,8 +40,8 @@ def fnmatch(name, pat):
If you don't want this, use fnmatchcase(FILENAME, PATTERN).
"""

name = name.lower()
pat = pat.lower()
name = os.path.normcase(name)
pat = os.path.normcase(pat)
return fnmatchcase(name, pat)


Expand Down
9 changes: 9 additions & 0 deletions tests/unit/utils_build_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,15 @@ def test_single_filename(self):
self.all_paths - {'a.py'}
)

@pytest.mark.skipif(
IS_WINDOWS_PLATFORM, reason='Windows pattern matching folds case'
)
def test_filename_pattern_is_case_sensitive(self):
from docker.utils.build import Pattern

assert Pattern('README.md').match('README.md')
assert not Pattern('README.md').match('readme.md')

def test_single_filename_leading_dot_slash(self):
assert self.exclude(['./a.py']) == convert_paths(
self.all_paths - {'a.py'}
Expand Down