Skip to content

tests: isolate FromContextTest from ambient TLS env vars #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardobranco777 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: isolate FromContextTest from ambient TLS env vars #3431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/unit/client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,13 @@ class FromContextTest(unittest.TestCase):

def setUp(self):
self.os_environ = os.environ.copy()
# Make sure DOCKER_HOST does not short-circuit the context path
# Make sure DOCKER_HOST does not short-circuit the context path,
# and that ambient DOCKER_TLS_VERIFY/DOCKER_CERT_PATH from the host
# running the tests don't leak into kwargs_from_env.
os.environ.pop('DOCKER_HOST', None)
os.environ.pop('DOCKER_CONTEXT', None)
os.environ.pop('DOCKER_CERT_PATH', None)
os.environ.pop('DOCKER_TLS_VERIFY', None)

def tearDown(self):
os.environ.clear()
Expand Down