Repository navigation
feat: redraw the startup banner art to spell MSCLI - #4559
Closed
abderrazzakchabab wants to merge 1 commit into
Closed
abderrazzakchabab wants to merge 1 commit into
abderrazzakchabab wants to merge 1 commit into
Conversation
Redraws the TUI startup banner in the same ASCII-art font so it spells MSCLI instead of the product name, and updates Width/Height to the new art dimensions used by the small-viewport check.
aheritier
added
area/tui
Collaborator
|
👋 Some commits in this PR are not signed and verified by GitHub. Please sign your commits with a GPG or SSH key registered in your GitHub account, then force-push. Commits that are not verified: See GitHub's guide on signing commits for setup instructions. I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TUI startup banner is redrawn in the same block-letter style so it spells
MSCLIinstead of the product name. The exportedWidth/Heightconstants inpkg/tui/bannerare updated to the new art dimensions used by the small-viewport check. Layout, styling, padding, subtitle/version lines and every other user-visible string are unchanged, as is the module path, package names, command name and everything else.Validation performed:
go build ./...— exit 0go test ./pkg/tui/... ./pkg/leantui/...— all packages greenstyles.BaseStyle.Foreground(styles.Accent)thenlipgloss.Place), which prints the new art centered in the accent colorgofmt -lclean on the changed file