Repository navigation
test(eval): avoid ETXTBSY in parallel fake-runtime tests - #4556
Merged
Merged
Conversation
Write fake container runtime scripts before t.Parallel and symlink them from each subtest's temp dir, so forked children don't inherit a writable executable fd and hit ETXTBSY on Linux. Assisted-By: cagent
dgageot
enabled auto-merge
October 8, 2026 16:24
mpailloncy
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the existing Linux flake exposed by #4554:
TestRunDockerAgentInContainerUsesConfiguredRuntimefailed to execute its freshly writtenfake-podmanscript withtext file busy(CI log).The affected tests write executable scripts after entering
t.Parallel(). A concurrent fork can inherit a writable descriptor until its child reaches exec, causing Linux to reject execution withETXTBSYeven afteros.WriteFilereturns.build_test.gopattern.Related to #4554; this does not modify or close that dependency-upgrade PR.
Validation
task buildtask testtask lintusing official golangci-lint v2.13.2 built with Go 1.27.0pkg/evaluationtest binary: 100 repetitions with-test.shuffle=on -test.parallel=32on Linux/arm64 in Docker, built with Go 1.27.0The baseline stress run did not reproduce the flake. Local Linux validation was arm64, not CI's amd64; CI validation is pending.