Make run.go easier to read

[dgageot]

No description provided.

[docker-agent]

Assessment: 🟡 NEEDS ATTENTION

This refactoring extracts profiling and recording logic into separate packages, improving code organization. However, there is one design issue in the new profiling API that should be addressed.

[docker-agent]

MEDIUM: Error Handling Issue

The Stop function signature returns nothing (func()), which prevents callers from detecting when profile writing fails. If memory profile creation fails (e.g., disk full, permission denied), the error is only logged via slog.Error but the caller has no way to know the profile wasn't written.

Recommendation:
Consider changing the Stop type to return an error:

type Stop func() error

Then aggregate errors from all closers:

return func() error {
    var errs []error
    for i := len(closers) - 1; i >= 0; i-- {
        if err := closers[i](); err != nil {
            errs = append(errs, err)
        }
    }
    if len(errs) > 0 {
        return fmt.Errorf("profiling cleanup errors: %v", errs)
    }
    return nil
}

This allows callers to detect and handle profiling failures appropriately.