fix(compose): report EventProcessor success correctly - #14141
Open
felix314159 wants to merge 1 commit into
Open
Conversation
Signed-off-by: felix h <felix314159@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix
Runpassing an invertedsuccessvalue toEventProcessor.Done. Successful operations now reporttrue, while failed operations reportfalse. I also added tests covering both outcomes.Note: #14074 also claims that
compose commit --dry-runcreates an image becauseDryRunClient.ContainerCommitdelegates to the real client. But I think that that claim is outdated: the supported Compose commit path already checkss.dryRunand returns before callingContainerCommit.Related issue
Relates to #14074