build: error messages name the real remedy, not a removed builder - #14133
Merged
Conversation
The classic-builder rejections said 'set DOCKER_BUILDKIT=1 to use BuildKit', a leftover from the internal BuildKit builder removed in af579eb. Since then BuildKit builds go through the buildx plugin: compose falls back to the classic builder when BuildKit is disabled (DOCKER_BUILDKIT=0) OR when buildx is not installed — so the advertised fix does nothing for users who are simply missing buildx. The five messages now state the actual requirement (buildx installed, DOCKER_BUILDKIT not forced to 0), and the silent-fallback warning when buildx is missing now says what the fallback implies instead of a bare 'requires buildx plugin to be installed'. Part of docker#14074 (A: the code misdescribes its own structure). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR is a pure wording-only update: five classic-builder feature-gate errors replaced a stale remedy (DOCKER_BUILDKIT=1) with accurate guidance (install buildx, don't force DOCKER_BUILDKIT=0), and the silent buildx-missing fallback warning now explains its consequences. No logic, control flow, or data handling is changed. The new messages are substantively more accurate than the old ones.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five classic-builder rejections advertised
DOCKER_BUILDKIT=1, a remedy tied to the internal BuildKit builder removed long ago. They now name the actual requirement (buildx plugin installed,DOCKER_BUILDKITnot forced to 0), and the silent buildx-missing fallback warning states its consequences. Only user-visible wording changes (e2e assertions updated).Epic #14074, section A — split out of #14075 for focused review.
🤖 Generated with Claude Code