chore(compose): rename convergence.go, whose convergence engine no longer exists - #14129
Conversation
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Pure rename/refactor — no logic changes. The updated filename reference in create.go, the new file-level doc comment, and the accurate getScale() doc comment all look correct. No issues found.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
The convergence.go → service_containers.go rename is missing 3 references to the old filename
- pkg/compose/reconcile.go:719 — comment // Nothing to do (exited containers are left as-is, matching convergence.go behavior)
- pkg/compose/reconcile.go:1012 — comment // sortContainers sorts containers the same way as convergence.go:138-160:
- pkg/compose/reconcile_test.go:1245 — comment // Exited containers are left as-is, matching convergence.go:199 behavior
Since the whole point of this PR (epic #14074, section A) is to fix misleading pointers to this file, it'd be worth folding these into the same change rather than leaving them for a follow-up.
…nger exists The convergence type this file was named after was removed in fbea647, but the file kept its name and its doc comment ('convergence manages service's container lifecycle') ended up attached to the unrelated getScale(). Anyone asked to 'change the convergence logic' lands here, while the actual reconciliation lives in reconcile.go. The file is renamed to service_containers.go with a header stating what it really contains: the per-service container helpers shared by both lifecycle engines (naming, service-reference resolution, dependency waiting, container creation, startup). getScale gets a doc comment that describes getScale. Part of docker#14074 (A: the code misdescribes its own structure). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
Good catch — folded into the rename commit (1bc908e): the three references now point at Note on the two |
8037cd5 to
1bc908e
Compare
3 participants
The
convergencetype was removed long ago but the file kept its name, and its doc comment ("convergence manages service's container lifecycle") sat on top of the unrelatedgetScale(). Renamed toservice_containers.goto match its actual content (naming, dependency waiting, container creation, start helpers).Epic #14074, section A — split out of #14075 for focused review.
🤖 Generated with Claude Code