Validate bind source for create_host_path false#13889
Open
scarab-systems wants to merge 1 commit into
Open
Conversation
scarab-systems
changed the title
Return an error before container creation when a bind mount explicitly disables host path creation and the resolved source path is missing. Add unit and end-to-end coverage for the create_host_path:false bind-source contract. Signed-off-by: Scarab Systems <scarab.systems@yahoo.com>
scarab-systems
force-pushed
the
13602-create-host-path-false
branch
from
13e158f to
fbde4b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added Compose-side validation for bind mounts that set
bind.create_host_path: false.Compose now returns a missing bind source error before container creation when the resolved bind source path does not exist. This keeps the
create_host_path: falsecontract enforced without relying on daemon or Desktop path handling.I also added unit and end-to-end coverage for
docker compose run --rmwith a missing long-syntax bind source.Related issue
Related to #13602
Validation
go test ./pkg/compose -run 'TestBuildContainerVolumesReturnsErrorWhenBindSourceMissingAndCreateHostPathFalse|Test_buildContainerVolumes' -count=1go build -trimpath -tags e2e -o bin/build/docker-compose ./cmdgo test -v -count=1 ./pkg/e2e -run TestRunDoesNotCreateMissingBindSourceWhenCreateHostPathIsFalsedocker buildx bake lint