test: Set stop_signal to SIGTERM in nginx-based services#13881
Open
ricardobranco777 wants to merge 1 commit into
Open
test: Set stop_signal to SIGTERM in nginx-based services#13881ricardobranco777 wants to merge 1 commit into
ricardobranco777 wants to merge 1 commit into
Conversation
The official nginx images set STOPSIGNAL to SIGQUIT which dumps core. Set it to SIGTERM to avoid dumping core on e2e tests when containers running "sleep infinity" are stopped. Signed-off-by: Ricardo Branco <rbranco@suse.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates an e2e watch fixture to stop nginx-based test containers with SIGTERM instead of inheriting the nginx image default STOPSIGNAL (SIGQUIT), which can generate core dumps during test teardown.
Changes:
- Set
stop_signal: SIGTERMfor thebackendservice inpkg/e2e/fixtures/watch/rebuild-deps.yaml. - Set
stop_signal: SIGTERMfor thefrontendservice in the same fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official nginx images set STOPSIGNAL to SIGQUIT which dumps core. Set it to SIGTERM to avoid dumping core on e2e tests when containers running
sleep infinityare stopped.Mirrors similar fix done in #13214
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did