docs(stop): say --timeout 0 is immediate SIGKILL - #7215
Open
locker95 wants to merge 3 commits into
Open
Conversation
The flag table shows Default 0, which looks like the daemon default. Omitting the flag still uses the container or daemon timeout. Signed-off-by: Dean Chen <862469039@qq.com>
Member
We should probably look at fixing that; the 
Compared to the generated docs on GitHub; 
|
Cobra's zero value made the generated table look like the daemon default. Clearing DefValue matches --help and docs.docker.com. Signed-off-by: Dean Chen <862469039@qq.com>
Author
|
cleared cobra's DefValue so the generated table does not print 0. should match --help / the published docs now. |
container stop/restart were already cleared; the top-level stop and restart pages still printed cobra's zero value. Signed-off-by: Dean Chen <862469039@qq.com>
Author
|
yeah, that 0 was cobra's zero value leaking into the generated table. --help was already right. I cleared DefValue so the man pages match, including the stop/restart aliases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the options table shows
--timeoutdefaulting to 0, which reads like stop just kills the container. omitting the flag still uses the container--stop-timeoutor the daemon default;--timeout 0is the immediate SIGKILL.same note on restart.