Skip to content

history: don't import build package#3646

Merged
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:urlutil
Feb 11, 2026
Merged

history: don't import build package#3646
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:urlutil

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 9, 2026

Moves IsHTTPURL and IsRemoteURL to dedicated package to avoid history package to import the build package. This is necessary in our Desktop build backend where we want to use the BuildName func there otherwise it fails to import packages that live only in BuildKit private fork.

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check CI. Otherwise ok.

@crazy-max crazy-max requested a review from tonistiigi February 10, 2026 07:58
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 7940a96 into docker:master Feb 11, 2026
159 checks passed
@crazy-max crazy-max deleted the urlutil branch February 11, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments