Move oci-import (and SBOM) shell code out of meta.jq into an explicit shell script#124
Merged
tianon merged 3 commits intodocker-library:mainfrom Apr 30, 2025
Merged
Move oci-import (and SBOM) shell code out of meta.jq into an explicit shell script#124tianon merged 3 commits intodocker-library:mainfrom
oci-import (and SBOM) shell code out of meta.jq into an explicit shell script#124tianon merged 3 commits intodocker-library:mainfrom
Conversation
…icit shell script Also, add a *lot* more validation. This new script/code assumes we're setting `BASHBREW_META_SCRIPTS` to an appropriate value (pointing to the directory of this repository on-disk).
Member
Author
|
(I made tianon/dockerfiles#982 so I could actually test this in a real load-bearing way) |
Member
Author
|
I made this as two separate commits so that the delta between the output of the old "oci-import" builder and the new "oci-import" builder can be plainly and clearly seen in the second commit (because I added a test all by itself in the first). |
yosifkit
reviewed
Apr 29, 2025
Comment on lines
+216
to
+217
| | if has("os.string") then | ||
| validate(."os.string"; type == "string" and length > 0) |
yosifkit
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, add a lot more validation.
This new script/code assumes we're setting
BASHBREW_META_SCRIPTSto an appropriate value (pointing to the directory of this repository on-disk).