Skip to content

Support multi-line backend extras with line separator ||#90

Open
chrsch wants to merge 1 commit intodocker-flow:mainfrom
innoxchain:multi-line_backend_extras
Open

Support multi-line backend extras with line separator ||#90
chrsch wants to merge 1 commit intodocker-flow:mainfrom
innoxchain:multi-line_backend_extras

Conversation

@chrsch
Copy link

@chrsch chrsch commented Jan 9, 2019

This is a first step to provide a solution for #85.

If someone could point out how to bring on the BackendExtraMultilineSeparator option I can implement this as well.

@thomasjpfan
Copy link
Contributor

Thanks for the PR!

Editing how the template process strings, would make the code harder to follow. I would prefer BackendExtra be edited when GetServiceFromProvider here:

func GetServiceFromProvider(provider ServiceParameterProvider) *Service {
In GetServiceFromProvider, the backendExtraMultilineSeparator can be queried. If it is defined and has a non-zero length, it can be used to separate BackendExtra into multiple lines.

  • Test in types_test.go to make sure that BackendExtra is separated correctly.
  • This new feature would need to be documented in usage.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants