Support multi-line backend extras with line separator ||#90
Open
chrsch wants to merge 1 commit intodocker-flow:mainfrom
Open
Support multi-line backend extras with line separator ||#90chrsch wants to merge 1 commit intodocker-flow:mainfrom
chrsch wants to merge 1 commit intodocker-flow:mainfrom
Conversation
Contributor
|
Thanks for the PR! Editing how the template process strings, would make the code harder to follow. I would prefer docker-flow-proxy/proxy/types.go Line 326 in acff954 GetServiceFromProvider, the backendExtraMultilineSeparator can be queried. If it is defined and has a non-zero length, it can be used to separate BackendExtra into multiple lines.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step to provide a solution for #85.
If someone could point out how to bring on the
BackendExtraMultilineSeparatoroption I can implement this as well.