Open
Conversation
patricklucas
requested changes
Apr 24, 2018
Member
patricklucas
left a comment
patricklucas
left a comment
There was a problem hiding this comment.
This is a nice solution to this problem, thank you. Just a few comments.
What do you think about gating all the parts to this strategy—the initContainer, volumeMount, and volume—with a check to see if .Values.flink.additional_libs is non-empty?
It would make the chart slightly more complicated, but I'm not sure how I feel about making the default behavior to populate an emptyDir with the same set of libs that are already there. What do you think?
| spec: | ||
| initContainers: | ||
| - name: flink-copy-libs | ||
| image: {{ .Values.image }}:{{ .Values.imageTag }} |
Member
There was a problem hiding this comment.
The init container should probably also respect imagePullPolicy. (also in deployment-taskmanager.yaml)
| command: | ||
| - sh | ||
| - -c | ||
| - cp /opt/flink/lib/* {{ range .Values.flink.additional_libs}}/opt/flink/opt/{{ . }} {{ end }} /flink-lib; |
Member
There was a problem hiding this comment.
minor style: space after additional_libs (also in deployment-taskmanager.yaml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds a config flag (
flink.additional_libs) that allows users to reference and include addtional libraries from the flink distribution. this is useful e.g. if you want to enable metrics but don't want to create a custom image for that. Basically what happens is that an init container (that runs the same image as jobmanager and taskmanager) mounts anemptyDir, copies the relevant libs from$FLINK_BASEDIR/liband$FLINK_BASEDIR/opt(<-- those are the ones that you can reference via--set flink.additional_libs) to thatemptyDirand mounts that directory in the jobmanager and taskmanager containers to/opt/flink/lib.