Fixes Git Issue 102 via commenting out line in lib/Crypt/LE.pm#107
Open
ajmetz wants to merge 1 commit intodo-know:masterfrom
Open
Fixes Git Issue 102 via commenting out line in lib/Crypt/LE.pm#107ajmetz wants to merge 1 commit intodo-know:masterfrom
ajmetz wants to merge 1 commit intodo-know:masterfrom
Conversation
[ 30/SEP/2025 AJMETZ ] - commented out line 674 ( $key->use_pkcs1_padding; ) following advice expressed in discussion of Git Issue 102 [ do-know#102 ] and feedback on an earlier pull request [ do-know#103 (review) ]. This will effectively delegate to Crypt::OpenSSL::RSA to set a default padding, and avoid the likes of errors such as: "PKCS#1 1.5 is disabled as it is known to be vulnerable to marvin attacks."
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ 30/SEP/2025 AJMETZ ] - commented out line 674 in master branch (or 654 in 0.39 release tag) ( $key->use_pkcs1_padding; ) following advice expressed in discussion of Git Issue 102 [ https://github.com//issues/102 ] and feedback on an earlier pull request [ https://github.com//pull/103#pullrequestreview-3220666378 ]. This will effectively delegate to Crypt::OpenSSL::RSA to set a default padding, and avoid the likes of errors such as: "PKCS#1 1.5 is disabled as it is known to be vulnerable to marvin attacks."