fix: switch isBrowser to Buffer existance check#121
Closed
nperez0111 wants to merge 1 commit into
Closed
Conversation
Owner
|
Makes total sense. I plan to separate browser and node environment (and deno etc.. ) into separate modules. That's why I want to keep the env-check in-place, rather duck typing whether Buffer is available (which might be polyfilled). I fixed this in the commit above and will make a release shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use the base64 encode & decode utilities within a WebWorker, which does not have access to the
windowordocumentglobal variables. I thought that a better check for these was actually to guard on the existance of a Buffer function.This should work in more runtimes (e.g. Deno & Bun), while also being slightly more correct.