feat(setValuesBulk): accept createMissing="sensitive" to create missing vars as sensitive#870
Open
Jarva wants to merge 1 commit into
Open
feat(setValuesBulk): accept createMissing="sensitive" to create missing vars as sensitive#870Jarva wants to merge 1 commit into
Jarva wants to merge 1 commit into
Conversation
…ng vars as sensitive
Member
|
Oh smart. I wonder if it should actually just be the default since usually you’ll be loading from vaults meant to hold secrets. 🤔 |
Author
|
I considered that too but as a third-party contributor I decided it was easier to implement an option than change the default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@setValuesBulk's createMissing option now accepts "sensitive" in addition to true/false. When set, keys created by the bulk source are marked sensitive regardless of @defaultSensitive, so their values are redacted in varlock load and other output instead of leaking as plain text.