Repository navigation
test: isolate PR env in requireBumpFile ci check tests - #170
Merged
Merged
Conversation
Tests read the host CI's GITHUB_HEAD_REF; on the version PR branch ci check skips, so the expected failures returned 0.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the environment isolation added to the requireBumpFile CI-check integration tests.
- Host environment isolation Saves and clears GitHub PR variables before each nested test, pins the fixture branch, and restores the original values afterward.
- Regression coverage stability Prevents a host version-PR branch from activating
ciCheckCommand's release-branch skip and masking expected failures. - Verification The focused 15-test file passes under a deliberately hostile version-PR environment, and
@varlock/bumpytype checking passes.
gpt-5.6-sol ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the version PR (#156) CI failure:
ci checktests inheritedGITHUB_HEAD_REF=bumpy/version-packagesfrom the host run, hit the release-branch skip, and exited 0. Pins the PR env in the describe block, matchingdep-bump-files.test.ts.