fix(file_history): use file.revs in open_in_diffview (#231)#232
Merged
Conversation
The listener cast `file.layout` to `Diff2` and read `.a.file.rev` / `.b.file.rev`, which crashes under `diff1_*` layouts where the layout has no `.a` window. Use `file.revs` directly -- it is the canonical rev pair on every `FileEntry` regardless of layout. Also drop a stale `@as Diff2` annotation on `default_layout` in `file_history_panel.lua`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listener cast
file.layouttoDiff2and read.a.file.rev/.b.file.rev, which crashes underdiff1_*layouts where the layout has no.awindow. Usefile.revsdirectly -- it is the canonical rev pair on everyFileEntryregardless of layout.Also drop a stale
@as Diff2annotation ondefault_layoutinfile_history_panel.lua.Fixes #231.