chore: Remove defunct classes#2515
Merged
Merged
Conversation
trisyoungs
force-pushed
the
dissolve2/remove-defunct-classes
branch
2 times, most recently
from
2bc86f7 to
6e0ef41
Compare
RobBuchananCompPhys
approved these changes
Jun 17, 2026
trisyoungs
force-pushed
the
dissolve2/remove-defunct-classes
branch
from
11dbd93 to
e2fbaa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick PR to remove several defunct classes:
Distributor-related classes - these haven't been in use since the removal of MPI.ChangeStoreandChangeData- used by MPI-parallelised routines, and hence also defunct.DataSource- this was an unfinished attempt to allow seamless specification of aDataNDsource, either an internal data (in processingModuleData_) or an external file. Primarily it was for theCompareModule, but this now doesn't exist inNodeform as there was no clear analogue.