docs(intent): step args are checked per kind - #189
Merged
Conversation
A step's args:, a process trigger:/abortOn:, a glue event: binding and the blocks nested in them are fixed vocabularies, so an invented key - or one belonging to another step kind, which the step reads just as little - now fails validation. Documents both messages and narrows the free-form list to the maps whose keys are names from the application being described.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents eclipse-dirigible/dirigible#6751 (closes eclipse-dirigible/dirigible#6749), the follow-up to the unknown-key rule shipped in #6748.
intent-file.md's Unknown keys are errors, never silent section now describes three checked shapes instead of two: the DSL's own keys, a seed row's keys, and a fixed-vocabulary block written as a mapping (a processtrigger:/abortOn:, a glueevent:binding including a step binding's{ process, step }, a posting'srule:, aforEach:, a lookup's outcome blocks, and the boundary-timer / notify blocks nested in a step).Adds the per-kind rule for a step's
args:with both real messages — an invented argument and one belonging to another kind, which the step reads just as little — and narrows the free-form list to the maps whose keys are names from the application being described (map:/defaults:, a relation'swhere:, a widget'sat:, a delegate's injectedfields:).Built locally with
npm run docs:build.