Conversation
Check that the URL constructor and window.location.href exist before parsing console.level/console.lock query vars at load time. Hybrid runtimes such as Tabris.js expose a window.location object but lack the URL global and location.href, so loading the module threw "TypeError: undefined is not a constructor (evaluating 'new URL(window.location.href)')".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console-level block in
lib/log.jsguards onwindow.locationand then callsnew URL(window.location.href). Two environments reach it and throw: one wherelocationexists buthrefis empty or absent, which is what jsdom and several React Native shims give you, and one withno global
URLconstructor at all. Either way importing forge fails outright, which is why thissurfaced as a
TypeErroron upgrade rather than as a missing log level.This widens the existing guard to require
window.location.hrefand a callableURLbefore theparse. Nothing else changes: where the parse worked before it still runs, and where it would have
thrown, forge now loads with the console logger at its default level.
Fixes #1117