Open
Conversation
… have a user option dropdown
…r, add comments, added boiler plate terms
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Feb 24, 2026
hospexplorer/ask/views.py
Outdated
| TermsAcceptance.objects.create( | ||
| user=request.user, | ||
| terms_version=current_version, | ||
| ip_address=ip_address, |
Member
There was a problem hiding this comment.
I don't think we need to store the ip address. Since we have user accounts, I would think it's enough to attach the terms to a user account.
Member
There was a problem hiding this comment.
is that really not needed anymore?
Contributor
Author
There was a problem hiding this comment.
I deleted this file and re applied migration (is_error is applied in the initial migration now instead of 2nd migration) since there were a lot of conflicts with QARecord and TermsAcceptance migrations.
Member
|
Resolve conflicts please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
Terms of Use Functionality
Description
Description
We want to include a terms of use functionality. I’d say for now, two things:
when logging in for the first time, the user needs to agree to the terms of use (some dummy text for now but it needs to be easily changeable, so e.g. in it’s own file that gets loaded by the app)
There needs to be a link to the terms of use file on the interface that the suer can click on at any time to read it. It should also show that the user agreed to it (if they did).
HOP-18
Anything else the reviewer needs to know?
... describe here ...