fix: anchor CLI socket under homedir instead of tmpdir - #64
Open
PriyeshPandey2000 wants to merge 1 commit into
Open
fix: anchor CLI socket under homedir instead of tmpdir#64PriyeshPandey2000 wants to merge 1 commit into
PriyeshPandey2000 wants to merge 1 commit into
Conversation
App (Finder/Dock launch) and dapi (terminal launch) get different $TMPDIR values, so each computed a different socket path and dapi could never connect. Anchor the socket under ~/.diffusion-studio instead, which both processes agree on regardless of launch context. Closes diffusionstudio#60
|
@PriyeshPandey2000 is attempting to deploy a commit to the Diffusion Studio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
dapi always reports "not running" even when the app is up: app (Finder/Dock launch) gets no $TMPDIR so os.tmpdir() falls back to /tmp, while dapi (terminal launch) inherits the shell's $TMPDIR (/var/folders/.../T). Each computed a different socket path, so dapi's connect always hit ENOENT.
Fix
Anchor the socket under
~/.diffusion-studio(mode 0700) instead ofos.tmpdir(), so both processes agree on the same path regardless of launch context.Closes #60