Skip to content

Add a default condition to every export so require('apecs') resolves #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srikarsunchu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a default condition to every export so require('apecs') resolves #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,23 @@
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js"
"import": "./dist/index.js",
"default": "./dist/index.js"
},
"./react": {
"types": "./dist/react/index.d.ts",
"import": "./dist/react/index.js"
"import": "./dist/react/index.js",
"default": "./dist/react/index.js"
},
"./solid": {
"types": "./dist/solid/index.d.ts",
"import": "./dist/solid/index.js"
"import": "./dist/solid/index.js",
"default": "./dist/solid/index.js"
},
"./internal": {
"types": "./dist/internal.d.ts",
"import": "./dist/internal.js"
"import": "./dist/internal.js",
"default": "./dist/internal.js"
}
},
"files": [
Expand Down
19 changes: 19 additions & 0 deletions scripts/check-bundle.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* npm run build && node scripts/check-bundle.mjs
*/
import { readFileSync, readdirSync } from 'node:fs';
import { createRequire } from 'node:module';
import { join } from 'node:path';

const DIST = 'dist';
Expand Down Expand Up @@ -148,6 +149,24 @@ for (const [file, peer] of [
);
}

// Every entry must resolve for a CommonJS consumer too: the `default` condition
// is what a `require()` resolver matches, and Node ≥ 20.19 (the engines floor)
// loads the ESM file through it. Self-referencing by package name goes through
// the same exports map a consumer sees.
const require = createRequire(import.meta.url);
for (const subpath of ['apecs', 'apecs/react', 'apecs/solid', 'apecs/internal']) {
try {
require.resolve(subpath);
} catch (error) {
check(false, `${subpath} does not resolve for require(): ${error.code ?? error.message}`);
}
}
try {
check(typeof require('apecs').VERSION === 'string', 'require("apecs") does not load the entry');
} catch (error) {
check(false, `require("apecs") throws: ${error.code ?? error.message}`);
}

if (failures.length > 0) {
for (const failure of failures) {
console.error(`✗ ${failure}`);
Expand Down