Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.4.0 #188 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 15 15
Lines 2501 2501
=======================================
Hits 2481 2481
Misses 20 20 🚀 New features to boost your workflow:
|
Contributor
|
Thanks @stevenhua0320. Did you review the code and clean it up before sending? You may want to take a look and save me some time. |
Contributor
Author
|
Yes, I took the review of the code and did a bit cleaning for the code structure. I think the logic is right. Since we don't have a command line control to test this one, we might need to integrate it into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. With the assistance of Claude code (with some training to group standard), it mimics the original
atomeyeapp viewer and writes avestaviewer. Moreover, since vesta supports its specific file formatvesta, I also added ap_vestafor the parser with file that ends withvesta.Additionally, I noticed that I missed one call of snakecase method (
abcABGtocell_params), therefore, I also changed it in this PR.